Fix CrashLog editorconfig violations breaking the Windows build#14
Merged
Conversation
Three rules tripped on the Windows job (TreatWarningsAsErrors fires these as build breaks, not warnings): - IDE0058: StringBuilder fluent chains and Directory.CreateDirectory return values were ignored. Prefix with '_ = '. - IDE0330: .NET 9 introduced System.Threading.Lock, which the analyser now prefers over a plain object for the lock target. - IDE0370: the '!' on ex.StackTrace was unnecessary; the IsNullOrWhiteSpace check above it already narrows the type for the analyser. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
System.Threading is in the SDK's implicit-usings set, so the explicit using directive trips IDE0005 (which TreatWarningsAsErrors turns into a build break). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
14b72e1.TreatWarningsAsErrors, all inCrashLog.cs:IDE0058: discardedStringBuilderfluent chains andDirectory.CreateDirectoryreturns — fixed with_ =.IDE0330: .NET 9's newSystem.Threading.Lockis preferred over a plainobjectlock target.IDE0370: the!onex.StackTracewas unnecessary; theIsNullOrWhiteSpacecheck above already narrows for the analyser.Test plan
🤖 Generated with Claude Code